Skip to content

chore: Add Taskfile tasks to lint YAML files. - #9

Merged
LinZhihao-723 merged 7 commits into
y-scope:mainfrom
Bill-hbrhbr:add-yaml-lint
Jan 22, 2025
Merged

chore: Add Taskfile tasks to lint YAML files.#9
LinZhihao-723 merged 7 commits into
y-scope:mainfrom
Bill-hbrhbr:add-yaml-lint

Conversation

@Bill-hbrhbr

@Bill-hbrhbr Bill-hbrhbr commented Jan 18, 2025

Copy link
Copy Markdown
Collaborator

Description

This PR sets up the basic task configuration files and linting tasks for Yaml files.
Note that for the task file naming convention, lowercase filenames are used, and the suffix .yaml is used. This is consistent with the practice applied in spider.

Additionally:

  • Apart from the top-level task file, all helper task files will be placed in the tasks/ directory.
  • Yaml attributes that are lists now consistently use hyphens across multiple lines instead of square brackets on one line.

Validation performed

  • The linting process for Yaml files completes successfully.

@davidlion davidlion left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On top of the comments lets make 2 changes:

  1. rename the directory tasks/ to taskfiles/
  2. drop the -tasks suffix inside this directory (e.g. rename lint-tasks.yaml to lint.yaml)

Comment thread lint-requirements.txt
Comment thread tasks/lint-yaml-tasks.yaml Outdated
@Bill-hbrhbr
Bill-hbrhbr requested a review from davidlion January 21, 2025 18:22
@LinZhihao-723
LinZhihao-723 merged commit 775d614 into y-scope:main Jan 22, 2025
@Bill-hbrhbr
Bill-hbrhbr deleted the add-yaml-lint branch February 3, 2025 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants